-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][MIG] geoengine_base_geolocalize migration #155
Conversation
fa0bbc0
to
4b0d5c4
Compare
"""Get the latitude and longitude by requesting "mapquestapi" | ||
see http://open.mapquestapi.com/geocoding/ | ||
""" | ||
url = 'http://nominatim.openstreetmap.org/search' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it is an openstreetmap class then could it make sens to externalize this one into a class attribute _url
?? (in order to reuser request into other call?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. I also thought about using a config parameter but I think it doesn't make sense as this URL will maybe never change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a litle question otherwise seems ok
4b0d5c4
to
ad9bece
Compare
527e215
to
2051fc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm in production. Thank you @lmarion-source
…on of localization using either point or lat/long
2051fc8
to
2050be1
Compare
Squashed commit of the following: commit 527e215 Author: Lindsay <[email protected]> Date: Tue Jun 2 14:47:52 2020 +0200 fixing typo commit dd9c3ec Author: Lindsay <[email protected]> Date: Tue Jun 2 14:42:47 2020 +0200 fixing pylint travis commit 7899f9b Author: Lindsay <[email protected]> Date: Tue Jun 2 14:05:25 2020 +0200 fix travis flake8 linting commit 039e867 Author: Lindsay <[email protected]> Date: Tue Jun 2 13:54:07 2020 +0200 fix travis pylint commit fcfb09e Author: Lindsay <[email protected]> Date: Tue Jun 2 13:45:09 2020 +0200 fixing travis tests commit ff2b39e Author: Lindsay <[email protected]> Date: Tue Jun 2 12:07:45 2020 +0200 fix import commit cdf43dc Author: Lindsay <[email protected]> Date: Tue Jun 2 11:47:21 2020 +0200 add responses to travis for testing commit 79da0ee Author: Lindsay <[email protected]> Date: Tue Jun 2 11:40:55 2020 +0200 disable pylint warning W0622 commit d6eab49 Author: Lindsay <[email protected]> Date: Tue Jun 2 10:29:58 2020 +0200 formatting for linters
2050be1
to
6eea371
Compare
/ocabot merge patch |
On my way to merge this fine PR! |
This PR has the |
Congratulations, your PR was merged at 317017d. Thanks a lot for contributing to OCA. ❤️ |
Also moved the openstreetmap api call in specific module.
@lmignon Your review is welcome!